Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Simplify registration proccess #51

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

Ramarti
Copy link
Contributor

@Ramarti Ramarti commented Jan 31, 2024

  • Continuing the simplification of licensing, there is no need for the concept of PolicyFramework as a data struct in LicenseRegistry, so we just use the framework address for ID and we move the related data to the PolicyFrameworkManager contract
  • Improving method naming for policy related operations in LicenseRegistry.
    -- addPolicy() is renamed registerPolicy() since it's the one well, registering data into LicenseRegistry
    -- Since we have PolicyFrameworkManager now, there is no need to pass Policy struct, just bytes data and LicenseRegistry will create the Policy object with the sender (the manager).
  • Removing unecesary and expensive event in UMLPolicyFrameworkManager

@Ramarti Ramarti changed the title Simplify registration roccess Simplify registration proccess Jan 31, 2024
@Ramarti Ramarti requested review from jdubpark, kingster-will and leeren and removed request for jdubpark and kingster-will January 31, 2024 20:38
@Ramarti Ramarti marked this pull request as ready for review January 31, 2024 20:39
@Ramarti Ramarti force-pushed the simplify_registration_proccess branch from cff69a1 to 9dede5c Compare February 1, 2024 00:25
@Ramarti Ramarti merged commit df2d708 into storyprotocol:main Feb 1, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants