This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Policy compatibility Part1 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 2, 2024 03:30
… unit/integration test plan
leeren
reviewed
Feb 2, 2024
LeoHChen
reviewed
Feb 3, 2024
jdubpark
suggested changes
Feb 3, 2024
test/foundry/mocks/licensing/MintPaymentPolicyFrameworkManager.sol
Outdated
Show resolved
Hide resolved
jdubpark
approved these changes
Feb 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts modifying the Policy Frameworks to support validity checks for the viability to set policies, mint licenses and set parents in the connected IP Graph.
LicenseRegistrynowStores separately policies added to an IP by the the owner, and inherited.
When adding a new policy, verifies feasibility, asking the policy framework to determine compatibility when a derivative with multiple parents is detected
Introducing a new
bytesvariable (rights) associated to each IpId, so it can be helpful to carry state when iterating over multiple policies when checkingWe move away from the typical unit test in favor of writing down the human readable test cases, as if it was integration tests, for the UMLPolicyFramework
Written down integration test cases