This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Switches core contracts to utilize relative imports #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches all core contracts to using relative imports. This is so that projects that declare
protocol-coreas a dependency do not run into any issues with path resolution, as evidenced by issues such as [this (https://github.com/foundry-rs/foundry/issues/3440) or this.As soon as a fix for the above has been found, we can switch back to absolute imports, as they provide cleaner semantics, but until then this will be best from a open-source development PoV, and why most major protocol repos do the same.