Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranges: Add index64_t constructor and deprecate index_t version #102

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Feb 13, 2020

The memory and iterator modules consistently use index64_t to specify sizes. However, ranges uses the configurable index_t type which may be different from index64_t. Add a corresponding index64_t constructor version to both device_range and host_range and deprecate the index_t version (only implicitly to avoid unnecessary noise).

@stotko stotko added this to the 1.3.0 milestone Feb 13, 2020
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #102 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   97.82%   97.83%   +<.01%     
==========================================
  Files          27       27              
  Lines        1609     1613       +4     
==========================================
+ Hits         1574     1578       +4     
  Misses         35       35
Impacted Files Coverage Δ
src/stdgpu/impl/ranges_detail.h 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98ee52...09b1e37. Read the comment docs.

@stotko stotko merged commit d7b2f18 into master Feb 13, 2020
@stotko stotko deleted the ranges_index_constructor branch February 13, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant