bit: Add ceil2 and floor2 functions #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 97.83% 97.84% +0.01%
==========================================
Files 27 27
Lines 1613 1624 +11
==========================================
+ Hits 1578 1589 +11
Misses 35 35
Continue to review full report at Codecov.
|
stotko
force-pushed
the
bit_ceil_floor
branch
from
c964a08
to
c7b2e6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally in
createDeviceObject,unordered_basecomputes the next power of two of the requested size which is used as the number of buckets. Since this kind of function is quite common, there is aceil2function (andfloor2respectively) in the upcoming C++20 standard. Add both of them and remove the internal auxiliary version inunordered_base. Furthermore, cleanup the unit test ofbitand fix a minor bug there.