Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,test: Improve consistency and cleanup includes #118

Merged
merged 4 commits into from
Mar 20, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Mar 20, 2020

Over time, some files were heavily refactored to improve their reliability. However, there is often some leftovers of this process including header includes. Cleanup these includes. Furthermore, make the internal workaround_* functions in the memory module mandatory to be defined by the backend modules. This improves the consistency of the required interfaces to implement a backend and clearly expresses the intent that this is not considered an optional feature.

@stotko stotko added the bug label Mar 20, 2020
@stotko stotko added this to the 1.3.0 milestone Mar 20, 2020
@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #118 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files          27       27           
  Lines        1648     1648           
=======================================
  Hits         1613     1613           
  Misses         35       35           
Impacted Files Coverage Δ
src/stdgpu/impl/iterator_detail.h 100.00% <ø> (ø)
src/stdgpu/iterator.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce99355...01a22ba. Read the comment docs.

@stotko stotko merged commit 7cab5cb into master Mar 20, 2020
@stotko stotko deleted the src_test_consistency_fixes branch March 20, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant