bitset: Remove dependency to cstdlib #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stotko
force-pushed
the
bitset_cstdlib_cleanup
branch
from
bc70790
to
b27bc2f
Compare
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 28 28
Lines 1703 1705 +2
=======================================
+ Hits 1663 1665 +2
Misses 40 40
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bitsetmodule is the only consumer of thecstdlibmodule.cstdlibitself only contains a helper function to compute the quotient and remainder of an integer division for the special case of power-of-2 divisors, which mixes parts ofcstdlibandbit. Remove the dependency tocstdlibsuch that this (helper) module may be deprecated in the future.