platform: Move STDGPU_HAS_CXX_17 to compiler #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 28 28
Lines 1705 1705
=======================================
Hits 1665 1665
Misses 40 40 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #119, automatic dispatching support has been added to the
platformmodule. However, this caused a regression inattributewhereSTDGPU_HAS_CXX_17becomes undefined due to include changes. Since the latter is closer related tocompilerrather thanplatform, move it to that place. Furthermore, extend the set of warnings to avoid such regressions in the future.