Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,test: Fix some minor warnings #147

Merged
merged 5 commits into from
May 1, 2020
Merged

src,test: Fix some minor warnings #147

merged 5 commits into from
May 1, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented May 1, 2020

Using -Weverything, Clang analyzes the code for any possible warning it knows about. Since not all of them are meaningful for most projects, we also do not enable it by default. Nevertheless, fix some of these warnings to cleanup the code.

@stotko stotko added the bug label May 1, 2020
@stotko stotko added this to the 1.3.0 milestone May 1, 2020
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #147 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   97.65%   97.59%   -0.06%     
==========================================
  Files          28       28              
  Lines        1705     1705              
==========================================
- Hits         1665     1664       -1     
- Misses         40       41       +1     
Impacted Files Coverage Δ
src/stdgpu/impl/memory_detail.h 98.61% <100.00%> (ø)
src/stdgpu/impl/unordered_base_detail.cuh 96.25% <100.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b73b9...8710c30. Read the comment docs.

@stotko stotko merged commit b863bba into master May 1, 2020
@stotko stotko deleted the src_test_minor_warnings branch May 1, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant