Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix error with unspecified build type #179

Merged
merged 1 commit into from
May 29, 2020
Merged

Conversation

stotko
Copy link
Owner

@stotko stotko commented May 29, 2020

In case CMAKE_BUILD_TYPE is not set by the user, expanding this variable will result in collapsing it in an expression and causing configuration errors in if clauses. Fix such an error by using the variable rather than its expanded value.

@stotko stotko added the bug label May 29, 2020
@stotko stotko added this to the 1.3.0 milestone May 29, 2020
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          28       28           
  Lines        1833     1833           
=======================================
  Hits         1793     1793           
  Misses         40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d005edc...7596b6b. Read the comment docs.

@stotko stotko merged commit 4fd45e4 into master May 29, 2020
@stotko stotko deleted the cmake_build_type branch May 29, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant