Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container: Add allocator member #191

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Container: Add allocator member #191

merged 3 commits into from
Oct 9, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Oct 9, 2020

In #56, all containers got a member function to return its allocator object. However, no explicit member object has been introduced so far due to compatibility reasons. Add this new allocator member object now and use it in the member functions. This makes the containers work correctly for allocators that have a state.

Fixes #62

@stotko stotko added this to the 2.0.0 milestone Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #191 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   97.78%   97.77%   -0.02%     
==========================================
  Files          28       28              
  Lines        1898     1885      -13     
==========================================
- Hits         1856     1843      -13     
  Misses         42       42              
Impacted Files Coverage Δ
src/stdgpu/deque.cuh 100.00% <ø> (ø)
src/stdgpu/impl/unordered_base.cuh 100.00% <ø> (ø)
src/stdgpu/vector.cuh 100.00% <ø> (ø)
src/stdgpu/impl/deque_detail.cuh 93.36% <100.00%> (-0.17%) ⬇️
src/stdgpu/impl/unordered_base_detail.cuh 96.45% <100.00%> (-0.05%) ⬇️
src/stdgpu/impl/vector_detail.cuh 93.75% <100.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f139b63...1acac0c. Read the comment docs.

@stotko stotko merged commit 2bb09e0 into master Oct 9, 2020
@stotko stotko deleted the allocator_member branch October 9, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container: Add allocator object member
1 participant