Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Remove optional NOTICE file #340

Merged
merged 1 commit into from
Mar 7, 2023
Merged

General: Remove optional NOTICE file #340

merged 1 commit into from
Mar 7, 2023

Conversation

stotko
Copy link
Owner

@stotko stotko commented Mar 7, 2023

Since the initial release of stdgpu, we also track and distributed a NOTICE file along with the license. However, this file is not necessary for project outside the Apache Software Foundation, see github/choosealicense.com#701 (comment). Thus, remove the file to avoid confusion and, in addition, reduce the maintenance burden.

@stotko stotko added this to the 2.0.0 milestone Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.12 🎉

Comparison is base (f669d75) 97.14% compared to head (a691dd1) 97.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   97.14%   97.27%   +0.12%     
==========================================
  Files          32       32              
  Lines        2346     2346              
==========================================
+ Hits         2279     2282       +3     
+ Misses         67       64       -3     
Impacted Files Coverage Δ
src/stdgpu/impl/deque_detail.cuh 94.57% <0.00%> (+1.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stotko stotko merged commit 8a20a56 into master Mar 7, 2023
@stotko stotko deleted the notice_file branch March 7, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant