Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utility: Add custom pair implementation #425

Merged
merged 1 commit into from
Jul 17, 2024
Merged

utility: Add custom pair implementation #425

merged 1 commit into from
Jul 17, 2024

Conversation

stotko
Copy link
Owner

@stotko stotko commented Jul 17, 2024

With thrust 2.3.0+ (bundled in CUDA 12.4+), their implementation of pair have been replaced by cuda:std::pair from libcudacxx. Unfortunately, this causes compiler errors due to ambiguous namespace resolution for overlapping functionality between stdgpu and libcudacxx. Replace the alias to thrust's pair class with a custom implementation to fix these issues.

This further reduces the dependency to thrust, see #279.

@stotko stotko added this to the 2.0.0 milestone Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (1b6a331) to head (6976d5b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   97.33%   97.38%   +0.05%     
==========================================
  Files          31       32       +1     
  Lines        2512     2524      +12     
==========================================
+ Hits         2445     2458      +13     
+ Misses         67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant