unordered_map,unordered_set: Increase excess size #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The excess size of
unordered_map
andunordered_set
have been estimated based on the birthday paradox and then conservatively lowered as some amount of estimated collisions also includes entries sitting in a bucket instead of the excess list. This size adjustment has been performed to save memory. However, the underlying assumption of this estimate is a perfect uniform distribution of the hashes which is the best case scenario. With common hash functions, that distribution may be worse leading to a larger amount of required excess entries, especially at high load factors. Use the estimated number directly as it overestimates the excess list size by a factor close to 2 (about 90% collisions will typically be between exactly 2 entries). This has been tested to work better with high load factors up to 100%.