unordered_{map,set}: Add single-parameter createDeviceObject function #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stotko
changed the title
stotko
force-pushed
the
unordered_base_container_size
branch
from
37c2e18
to
5d9b23b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to all other containers,
unordered_mapandunordered_sethave a 2-parameter version ofcreateDeviceObjectwhich is difficult to use since it requires the user to balance both "capacity" values and imposes a strict constraint to the first parameter. Add a 1-parameter version of this function (without such a constraint) that automatically estimates a suitable number of buckets and excess entries for the requested container capacity. Furthermore, add amax_load_factorfunction that returns the current/default maximum load factor that is taken into account for above estimation. Deprecate the old- 2-parameter function to encourage users to port/use the new version.