cmake: Fix minimum required version #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current minimum required CMake version is set to 3.13 since the project uses some of its newly introduced features. However, the project is configured to use the
NEWbehavior of more recent CMake policies until version 3.15. Since the CI uses the newest version, this effectively only verifies builds where the minimum required version would be set to 3.15.This caused a further implicit dependency getting unnoticed so far. When building on Windows, a further requirement is the
NEWbehavior of CMake policy CMP00091. Fix this issue by increasing the minimum required CMake version. Futhermore, increase the maximum version where policies are set toNEWto the most recent version 3.16.