Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic: Fix compare_exchange and add more operators as well as tests #83

Merged
merged 4 commits into from
Jan 14, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Jan 14, 2020

In #75, more unit tests have been introduced to increase the test coverage. However, some functions are still not yet tested. Extend the tests to cover all defined functions. Furthermore, add operator-versions of load() and store() and fix the behavior of compare_exchange_{weak,strong}.

@stotko stotko added this to the 1.2.0 milestone Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #83 into master will increase coverage by 1.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   92.74%   94.16%   +1.42%     
==========================================
  Files          27       27              
  Lines        1598     1610      +12     
==========================================
+ Hits         1482     1516      +34     
+ Misses        116       94      -22
Impacted Files Coverage Δ
src/stdgpu/impl/atomic_detail.cuh 100% <100%> (+10.43%) ⬆️
src/stdgpu/openmp/impl/atomic_detail.h 100% <0%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11b4cf...65c3307. Read the comment docs.

@stotko stotko merged commit c03210d into master Jan 14, 2020
@stotko stotko deleted the atomic_tests branch January 14, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant