Add functions to access single SecretVec items #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently SecretVec only allows borrowing an (im)mutable wrapper around the box slice. This means any struct using a SecretVec and holding open references to content inside need to hold both the borrowed SecretVec and the Box borrow produced by its methods. This commit adds `get`, `get_mut`, and an iterator for direct access to items without the Box borrow indirection. The types `ItemRef` and `ItemRefMut` preserve the locking rules while acting as a handle to individual values in the Box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SecretVec only allows borrowing an (im)mutable wrapper around the box slice. This means any struct using a SecretVec and holding open references to content inside need to hold both the borrowed SecretVec and the Box borrow produced by its methods. This commit adds
get,get_mut, and an iterator for direct access to items without the Box borrow indirection. The typesItemRefandItemRefMutpreserve the locking rules while acting as a handle to individual values in the Box.