feat: add append mode support to file_write tool #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhisheksp
requested a deployment
to
manual-approval
GitHub Actions
Waiting
abhisheksp
force-pushed
the
feat/file-write-append-mode
branch
from
8282737 to
46ccd01
Compare
abhisheksp
requested a deployment
to
manual-approval
GitHub Actions
Waiting
- Add optional 'mode' parameter with 'write' (default) and 'append' options - Maintain backward compatibility with default overwrite behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
abhisheksp
force-pushed
the
feat/file-write-append-mode
branch
from
46ccd01 to
24d996b
Compare
abhisheksp
had a problem deploying
to
manual-approval
GitHub Actions
Failure
cagataycali
approved these changes
Dec 29, 2025
abhisheksp
had a problem deploying
to
manual-approval
GitHub Actions
Failure
| "pytest>=8.0.0,<9.0.0", | ||
| "ruff>=0.13.0,<0.14.0", | ||
| "responses>=0.6.1,<1.0.0", | ||
| "botocore[crt]>=1.39.7,<2.0.0", |
Member
There was a problem hiding this comment.
Hi, why do we need a dependency change as part of this PR?
Member
There was a problem hiding this comment.
Which test would fail regarding Added botocore[crt] to dev dependencies to support agent interface tests
Author
There was a problem hiding this comment.
The botocore[crt] dependency fixes a pre-existing test failure in the agent interface tests.
The failure:
test_file_write_via_agenttest_file_write_append_via_agent
Both error with:
botocore.exceptions.MissingDependencyException: Using the login credential
provider requires an additional dependency. You will need to pip install
"botocore[crt]" before proceeding.
This isn't related to append mode - it's been broken. I caught it while running the full test suite. With botocore[crt] added, all 16 tests pass.
If you'd prefer, I can split this into a separate PR and keep this one focused on just the append mode feature. The core functionality (14 tests) works fine without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds append mode support to the
file_writetool, resolving the discrepancy between documentation and implementation where append functionality was mentioned but not implemented.Changes:
modeparameter accepting"write"(default) or"append"botocore[crt]to dev dependencies to support agent interface testsRelated Issues
Fixes #344
Documentation PR
N/A - Documentation updated in this PR (module docstrings and function docstrings)
Type of Change
Enhancement (new feature that adds functionality)
Testing
Test Coverage:
Pre-commit:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.