Fix UBD visualization code #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge yet, please |
|
Ok, ready for review/merge now. |
| @@ -311,6 +327,9 @@ void connectCallback(message_filters::Subscriber<CameraInfo> &sub_cam, | |||
|
|
|||
| int main(int argc, char **argv) | |||
| { | |||
| g_txt.push_back(QImage("/home/beyer/strands/0.png")); | |||
| g_txt.push_back(QImage("/home/beyer/strands/1.png")); | |||
| g_txt.push_back(QImage("/home/beyer/strands/2.png")); | |||
There was a problem hiding this comment.
I guess this will break for everyone else?
There was a problem hiding this comment.
Awww shit I was tired this is not supposed to be there, good catch!
|
That's more what it should be like. We've been running with this for 2 days now and had no crash. But still, I don't really believe this is the crash's cause, so I wouldn't close the issue. |
|
Tested on Linda, works fine for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might or might not solve #156. I believe it won't, but it's worth a try and fixes some latent bugs anyway.