-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[test] Add no-valgrind run test option
Valgrind on ubuntu 22.04 does not handle all eBPF commands. It's not because there is some kind of issue with valgrind, but rather there is a problem with ubuntu itself. I created two new virtual machines, one with debian, and the other one with ubuntu. On both of them, I installed valgrind from source code, following exactly same procedures on both VMs. On debian valgrind support all eBPF commands (or at least the commands that nhid uses), on ubuntu following error raise: ``` WARNING: unhandled eBPF command 28 ``` Therefore I decided not to run nhid via valgrind on github's ubuntu 22.04 VM.
- Loading branch information
1 parent
fe43dd9
commit 0f83bb4
Showing
3 changed files
with
21 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,4 +37,4 @@ jobs: | |
run: make build-test-daemon | ||
|
||
- name: Run tests | ||
run: sudo ./run-tests | ||
run: sudo ./run-tests no-valgrind |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,4 +3,4 @@ | |
set -e | ||
|
||
./testing/test-cli | ||
./testing/test-daemon | ||
./testing/test-daemon $1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters