review: simplify allConsumers to not use index

strangelove-ventures · Oct 3, 2024 · 188f6c9 · 188f6c9
1 parent db19bf9
commit 188f6c9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/local-interchain/chains/README.md b/local-interchain/chains/README.md
@@ -5,9 +5,8 @@
 Current the neutron heighliner image does not work due to some /tmp issue in the docker image. For this reason, you must compile the image yourself to use the latest v50 instance.
 
 ```bash
-git clone https://github.com/neutron-org/neutron.git
+git clone https://github.com/neutron-org/neutron.git --depth 1 --branch v4.2.1
 cd neutron
-git checkout v4.2.1
 
 # neutron-node:latest
 make build-e2e-docker-image

diff --git a/local-interchain/interchain/start.go b/local-interchain/interchain/start.go
@@ -146,14 +146,14 @@ func StartChain(installDir, chainCfgFile string, ac *types.AppStartConfig) {
  for provider, consumers := range icsPair {
  var p ibc.Chain
 
- allConsumers := make([]ibc.Chain, len(consumers))
- for idx, consumer := range consumers {
+ allConsumers := []ibc.Chain{}
+ for _, consumer := range consumers {
  for _, chain := range chains {
  if chain.Config().ChainID == provider {
  p = chain
  }
  if chain.Config().ChainID == consumer {
- allConsumers[idx] = chain
+ allConsumers = append(allConsumers, chain)
  }
  }
  }