Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Compatibility issues with SDK v0.47 queries #637

Closed
srdtrk opened this issue Jun 21, 2023 · 0 comments · Fixed by #638
Closed

[Bug] Compatibility issues with SDK v0.47 queries #637

srdtrk opened this issue Jun 21, 2023 · 0 comments · Fixed by #638

Comments

@srdtrk
Copy link
Contributor

srdtrk commented Jun 21, 2023

Summary

In SDK v0.47, the --chain-id flag in queries result in an error by default. So using it returns an error.

Description

I can't find an issue to link here for why --chain-id it was removed by default, but it was removed from simapp within this refactor. To demonstrate the issue, I'll use the following test example from one of my repos:

// ...
// Upload and Instantiate the contract on wasmd:
	codeId, err := wasmd.StoreContract(ctx, wasmdUser.KeyName(), "../../artifacts/cw_ica_controller.wasm")
	require.NoError(t, err)

store contract will always return an error in the latest version of wasmd (v0.40.2) because the StoreContract function checks whether it was successful via a query. But it will pass in an older version such as v0.32.1.

Proposal

The SDK team suggested that this flag is only passed to txs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant