feat(v7): override sdk v47 version check with env variable #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Reecepbcups
changed the title
Reecepbcups
approved these changes
Aug 21, 2024
Reecepbcups
reviewed
Aug 21, 2024
chain/cosmos/chain_node.go
Outdated
Comment on lines
741
to
745
| if env == "true" { | ||
| return true | ||
| } else { | ||
| return false | ||
| } |
There was a problem hiding this comment.
FYI could technically do return env == "true"
you java'ers like your elses lol
There was a problem hiding this comment.
🤦♂️ Yes, definitely would be more concise
Reecepbcups
changed the title
Reecepbcups
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually overrides the logic to determine if a chain is running SDK 47 or greater.