chore: fix linter warnings #1270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jtieri
changed the title
Reecepbcups
reviewed
Oct 4, 2024
| "github.com/stretchr/testify/require" | ||
| "go.uber.org/zap/zaptest" | ||
|
|
||
| "cosmossdk.io/math" | ||
|
|
||
| "github.com/cosmos/cosmos-sdk/types" | ||
|
|
||
| "github.com/strangelove-ventures/interchaintest/v8" |
There was a problem hiding this comment.
optional: add optional git hooks for vscode peeps
Reecepbcups
reviewed
Oct 4, 2024
| @@ -112,7 +108,7 @@ func TestDB_Concurrency(t *testing.T) { | |||
| for { | |||
| if ctx.Err() != nil { | |||
| // Context was canceled; querying is finished. | |||
| return nil | |||
| return nil //nolint: nilerr | |||
There was a problem hiding this comment.
remove since ignoring this linter type now
| @@ -191,7 +192,7 @@ func (tn *ChainNode) NewSidecarProcess( | |||
| VolumeName: v.Name, | |||
| ImageRef: image.Ref(), | |||
| TestName: tn.TestName, | |||
| UidGid: image.UidGid, | |||
| UIDGID: image.UIDGID, | |||
There was a problem hiding this comment.
user breaking - lets until v10 - create ticket for this. Don't want people to have to refactor their test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CI jobs for linting and running tests to use current deps. It also fixes all the linter warnings from
golangci-lint.