Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

ICS4Wrapper middleware flow #58

Merged
merged 1 commit into from
Jan 19, 2023
Merged

ICS4Wrapper middleware flow #58

merged 1 commit into from
Jan 19, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented Jan 19, 2023 •
edited
Loading

Since IBCMiddleware implements porttypes.Middleware, we no longer need to implement PortKeeper or ChannelKeeper in the router Keeper.

We can call the ICS4Wrapper for WriteAcknowledgement instead of the channelKeeper directly, but we still need channelKeeper for Transfer as the ICS4Wrapper SendPacket method does not return the sequence.

@agouin agouin requested a review from jtieri January 19, 2023 19:27
jtieri
jtieri approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agouin agouin merged commit 8fcfbc2 into v3 Jan 19, 2023
@agouin agouin deleted the andrew/remove_channel_port_keeper_impls branch January 19, 2023 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtieri jtieri jtieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agouin @jtieri