Skip to content

Conversation

Abdullahxz
Copy link
Contributor

@Abdullahxz Abdullahxz commented Jan 15, 2024

What does it do?

Fixes the misplaced Okta caution block on Single Sign-on page. It was misplaced under keycloak heading and users were unable to see if they visited https://docs.strapi.io/dev-docs/configurations/sso#okta url.

Before:
Screenshot from 2024-01-15 13-18-28

After:
Screenshot from 2024-01-15 13-18-47

Why is it needed?

Improves visibility and relevancy of the caution block.

@Abdullahxz Abdullahxz requested a review from pwizla as a code owner January 15, 2024 08:09
Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 8:13am

@strapi-cla
Copy link

strapi-cla commented Jan 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Abdullahxz!
It's approved, merged, should be live on docs.strapi.io in a few minutes, and will be mentioned in the next weekly snapshot release.

@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs pr: chore labels Jan 15, 2024
@pwizla pwizla added this to the 4.17.1 milestone Jan 15, 2024
@pwizla pwizla merged commit 93fae49 into strapi:main Jan 15, 2024
@Abdullahxz Abdullahxz deleted the dev/fix-misplaced-sso-caution-block branch January 16, 2024 06:22
pwizla added a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: chore source: Dev Docs PRs/issues targeting the Developer Docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants