Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: in Strapi project, init creates plugin in plugin path and logs config info #36

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

innerdvations
Copy link
Collaborator

@innerdvations innerdvations commented Aug 8, 2024

What does it do?

When init is run in Strapi project, create plugin in plugin path and log the config info

Why is it needed?

Makes init command more helpful

How to test it?

run init in the root of a Strapi project and it should generate the plugin in the ./src/plugins dir automatically instead of in the root of the project and it should:

  • suggest the path you provided as a packageName
  • output lines to add to plugins.ts or plugins.js [check that extension is correct]
  • have correct plugin config info even when path and packageName are different

run init anywhere else and it should:

  • suggest the path you provided as a packageName
  • NOT output lines to add to plugins config

Related issue(s)/PR(s)

implements #22

DX-1521

@innerdvations innerdvations added pr: feature New or updates to features source: sdk-plugin labels Aug 8, 2024
@innerdvations innerdvations self-assigned this Aug 8, 2024
Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 69e29d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@strapi/sdk-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@innerdvations innerdvations marked this pull request as ready for review August 8, 2024 15:10
Copy link
Collaborator Author

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Convly Your updates LGTM, can you review and approve my part? :)

@innerdvations innerdvations merged commit f5ddf69 into main Aug 14, 2024
2 checks passed
@innerdvations innerdvations deleted the feat/22-detect-strapi-project branch August 14, 2024 08:46
@echoes-hq echoes-hq bot added the echoes: enhancement Extensions to existing functionality, tests, tools and features label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: enhancement Extensions to existing functionality, tests, tools and features pr: feature New or updates to features source: sdk-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants