Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin loading #38

Merged
merged 14 commits into from
Aug 14, 2024
Merged

fix: plugin loading #38

merged 14 commits into from
Aug 14, 2024

Conversation

innerdvations
Copy link
Collaborator

@innerdvations innerdvations commented Aug 9, 2024

What does it do?

Fix imports for both typescript and javascript projects so that plugins load within Strapi 5

Still in draft because:

  1. waiting for the parent branch to be finished and merged
  2. I'm not sure if we actually want to remove the build process from javascript plugins, or fix building instead. If this is the correct approach, I will remove the build scripts from javascript. If it's the incorrect approach and we should be building, I will fix the build script to include all necessary files (currently only index is copied so js plugins are broken)

Why is it needed?

Currently, plugins created by init don't actually load in Strapi 5

How to test it?

generate new js and ts plugins; they should work fine in Strapi 5 without modification

Related issue(s)/PR(s)

fixes #33
fixes #35

DX-1518
DX-1519

Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: edea3e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@strapi/sdk-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@innerdvations innerdvations changed the base branch from main to feat/22-detect-strapi-project August 9, 2024 12:12
@innerdvations innerdvations marked this pull request as ready for review August 14, 2024 08:20
Base automatically changed from feat/22-detect-strapi-project to main August 14, 2024 08:46
An error occurred while trying to automatically change base from feat/22-detect-strapi-project to main August 14, 2024 08:46
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

Copy link
Member

@Bassel17 Bassel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@innerdvations innerdvations merged commit 52c55bf into main Aug 14, 2024
2 checks passed
@innerdvations innerdvations deleted the fix/35-content-type-error branch August 14, 2024 13:09
@echoes-hq echoes-hq bot added the echoes: bug Changes intended at preserving our ability to evolve the software safely and effectively label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bug Changes intended at preserving our ability to evolve the software safely and effectively pr: fix Bug fix source: sdk-plugin
Projects
None yet
3 participants