Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: admin jsconfig when building plugin in javascript #43

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

jhoward1994
Copy link
Contributor

@jhoward1994 jhoward1994 commented Aug 28, 2024

What does it do?

Adds a jsconfig.json file to the plugins frontend code

Why is it needed?

To fix TS build errors such as Cannot use JSX unless the '--jsx' flag is provided.ts(17004) when installing the plugin in a strapi v5 project

How to test it?

Build sdk-plugin from this branch
npx create-strapi-app@rc my-test-ap
From my-test-app run PATH_TO_THIS_REPO/bin/strapi-plugin.js init new
Ensure you can install and use the plugin with no build errors

Related issue(s)/PR(s)

DX-1548

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 188ab18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@strapi/sdk-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jhoward1994 jhoward1994 self-assigned this Aug 30, 2024
@jhoward1994 jhoward1994 marked this pull request as ready for review August 30, 2024 09:31
Copy link
Collaborator

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to switch the else { if { to an else if { for linting and then add a changeset

Copy link
Collaborator

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@innerdvations innerdvations merged commit 845a3b0 into main Sep 2, 2024
2 checks passed
@innerdvations innerdvations deleted the fix/admin-jsconfig branch September 2, 2024 12:01
@echoes-hq echoes-hq bot added the echoes: enhancement Extensions to existing functionality, tests, tools and features label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: enhancement Extensions to existing functionality, tests, tools and features pr: fix Bug fix source: sdk-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants