Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We would like CI to fail if the compiler generates warnings #159

Closed
mulkieran opened this issue Dec 1, 2016 · 4 comments
Closed

We would like CI to fail if the compiler generates warnings #159

mulkieran opened this issue Dec 1, 2016 · 4 comments
Assignees
@mulkieran

Comments

@mulkieran
Copy link
Member

Something like the gcc flag -Wall.

In theory, we should be able to do this by modifying the dev profile, but in practice, the profile does not seem to include anything to change this behavior.
@mulkieran mulkieran self-assigned this Dec 1, 2016
@agrover
Copy link
Contributor

agrover commented Dec 1, 2016

-Werror, but yeah.

@agrover
Copy link
Contributor

agrover commented Dec 1, 2016

rust-lang/rust#8496 (comment)

@mulkieran
Copy link
Member Author

rust-lang/cargo#60 final comment seems like it might helfp.

@mulkieran mulkieran mentioned this issue Dec 2, 2016
Merged
@mulkieran
Copy link
Member Author

Resolved by #161.

mulkieran added a commit to mulkieran/stratisd that referenced this issue May 23, 2019
@mulkieran
Merge pull request stratis-storage#159 from stratis-storage/pyup-upda…
91eb8ed 
…te-tox-3.1.1-to-3.1.2

Update tox to 3.1.2
mulkieran added a commit that referenced this issue Oct 24, 2021
@mulkieran
Merge pull request #159 from mulkieran/master-thindev
ad23793 
Change semantics of ThinDev::new and ThinDev::setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mulkieran mulkieran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agrover @mulkieran