Remove dbus enums final #1222
Merged
Remove dbus enums final #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops! You should fix up test infrastructure, too: |
|
fixes #1160 |
|
I don't understand, this PR updates _stratisd_constants.py. What further needs to be changed? |
mulkieran
previously approved these changes
Sep 26, 2018
tasleson
previously approved these changes
Sep 26, 2018
added 3 commits
September 26, 2018 10:29
Best to just use ERROR. fixes stratis-storage#1181 Signed-off-by: Andy Grover <agrover@redhat.com>
This is pretty much the same as an IO error. Users should not care about which crates Stratis is using. Signed-off-by: Andy Grover <agrover@redhat.com>
There's no bright-line between ERROR and IO_ERROR. Also, we should only try to have separate error types for cases users will conceivably check for and then do something, and IO_ERROR doesn't meet this test. Signed-off-by: Andy Grover <agrover@redhat.com>
agrover
force-pushed
the
remove-dbus-enums-final
branch
from
94f5fa4 to
a1e9500
Compare
trgill
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
final PR of #1204
fixes #1167