Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes corresponding to u128 changes to Bytes #1830

Closed
wants to merge 4 commits into from
Closed

Changes corresponding to u128 changes to Bytes #1830

wants to merge 4 commits into from

Conversation

jbaublitz
Copy link
Member

Supersedes #1703
Related stratis-storage/project#52

@jbaublitz jbaublitz self-assigned this Feb 20, 2020
@jbaublitz jbaublitz force-pushed the issue-project-52-u128 branch 4 times, most recently from b372451 to 5daee94 Compare February 28, 2020 15:23
@jbaublitz jbaublitz force-pushed the issue-project-52-u128 branch 3 times, most recently from 41f59ad to ff060da Compare April 8, 2020 13:38
@jbaublitz
Copy link
Member Author

jbaublitz commented Apr 20, 2020 •
edited
Loading

@mulkieran I'm attaching this as April but you can move it back as desired. The reason I'm bringing this up again is that I looked into the u128 stabilization issue on Github and it seems they've completed lowering u128s when they are not natively supported (see here). I'm not sure if you had additional concerns, but I just want to make sure we don't forget about this because of the code we had to introduce to work around this.

@mulkieran
Copy link
Member

Pushing back to May...too little time too review...the little hack in the D-Bus layer is just too localized to be worrisome.

@jbaublitz
Copy link
Member Author

Okay not a problem! Just wanted to make sure this doesn't get lost.

@jbaublitz jbaublitz force-pushed the issue-project-52-u128 branch 2 times, most recently from d15bd15 to 4d72d81 Compare May 16, 2020 22:09
@jbaublitz jbaublitz closed this Jul 1, 2020
@jbaublitz jbaublitz mentioned this pull request Jul 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbaublitz jbaublitz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbaublitz @mulkieran