The static members of Network and Consensus should be eliminated.

[ghost]

Instead, network and consensus should be passed around like a service or set to a single location like Consensus.Current, Network.Current. INetwork or IConsensus could add some flexibilty.

[dangershony]

Ho yeah I agree but the node generally doesn't use the static versions (only at startup)

[ghost]

ohh, it uses it in may places, believe me :-)

[dangershony]

In the fullnode? can you show me where?

[ghost]

some typical workarounds:

static Network()
{
if (!NetworkConfig.UseSingleNetwork)
{
_Main = new Network();
_Main.InitMain();
_Main.Consensus.Freeze();

			_TestNet = new Network();
			_TestNet.InitTest();
			_TestNet.Consensus.Freeze();

			_RegTest = new Network();
			_RegTest.InitReg();
		}
		
	}

public static IEnumerable GetNetworks()
{
if (!NetworkConfig.UseSingleNetwork) // don't yield null results
{
yield return Main;
yield return TestNet;
yield return RegTest;
}

[ghost]

public bool CheckProofOfWork() // Block.cs
	{
		return CheckProofOfWork(null);
	}

public bool CheckProofOfWork(Consensus consensus)
{
consensus = consensus ?? Consensus.Main; // you always get Consensus.Main.

[ghost]

There are perhaps 15 places or so where you get Network.Main or Consensus.Main (or Bitcoin RegTest) instead of e.g. StratisTest. Network is often not passed on, instead taken from the properties of the Network class, so it changes silently ;-)

[ghost]

public static Network Main // has 99 references!
{
get
{
return _Main;
}
}

[ghost]

Network.TestNet has 15 and Network.RegTest has 29 references. This all goes from if you want your 'other' Network and not one of the defaults :-)

[ghost]

for example, if you want to run the integration tests explicitly with the Stratis network, the work starts and when you work around it, you see that many tests will fail then, because the differences to BTC sum up. That means that the Stratis network is hardly covered by the integration tests.

[ghost]

closed this, to make a more detailed proposal!