This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
Improve quality score display in console when the score is less than 10 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alpho2k sorry just saw this pull request looks fine, can't you use the .PadRight() method instead? |
ghost
deleted the
andrasfuchs
referenced
this pull request
in AequitasCoinProject/AequitasFullNode
Jul 2, 2018
Merge with origin
codingupastorm
pushed a commit
that referenced
this pull request
Mar 10, 2019
* upgrade nuget 1.1.7 to 1.1.9 and 4.0.0.57 and 4.0.0.58 * add NLog * added CoinbaseMaturity, PremineReward, pow reward, pos reward and max reorg for the apex network. * new project for ApexNetwork * remove APexD dependency in IntegrationTest
YakupIpek
pushed a commit
to YakupIpek/StratisBitcoinFullNode
that referenced
this pull request
May 22, 2019
* upgrade nuget 1.1.7 to 1.1.9 and 4.0.0.57 and 4.0.0.58 * add NLog * added CoinbaseMaturity, PremineReward, pow reward, pos reward and max reorg for the apex network. * new project for ApexNetwork * remove APexD dependency in IntegrationTest
fassadlr
pushed a commit
that referenced
this pull request
Jun 19, 2019
* Created FedKeyPairGen console app. Imported from Changeset 124 * Upgraded SBFN verison in project files. Imported from Changeset 150 * Moved Payload into feature Imported from Changeset 154 * Changed 'passphrase' in FedKeyPairGen to 'password'. Imported from Changeset 198 * Attempt to merge Enigma and EnigmaChain Imported from Changeset 201 * Updated the solution with the latest Stratis.Bitcoin nuget packages Imported from Changeset 202 * Removed name, folder and password from the pubkey generation as they are not required. The console app will simply show the user their mnemonic and the pubkey they need to share. * Removed mine premine stuff and added it to the FedKeyPairGen console app for now. * Remove custom env mockup helpers (#5) * created Apex definition * first bit of cleaning, all the mockup helpers have been removed as no special logic is needed to handle sidechains, they are just another network. Need to add back randomised API port attribution. Need to fix getCoinDetails test if it is being used by anyone (UI ?). The powershell command projects have been removed as they were only here to generate json files that have disappeared. * delete unused projects * Bring back FindPorts methods to later find a way to use it * Fix to get different API ports when creating multiple connected nodes on localhost, fix to GetCoinDetails, a bit basic for the moment, but we'll see how the code evolved * Put explanatory name on the Class in FederatedSidechains.Tests.Common * this doesn't work, somehow the constructor is called twice, and once with a null nodesettings, I need to investigate * Changes after PR comments * more merge changes ... * fix get-coindetails logic * Removed placeholder project and wrongly copied MainchainGeneratorService * consolidate .Net Sdk * added code to generate multisig in FedKeyPairGen (#8) * Jeremy's PR 14 reproduced with pr5 changes in (#15) * upgrade nuget 1.1.7 to 1.1.9 and 4.0.0.57 and 4.0.0.58 * add NLog * Add new network properties to Apex * Update ApexNetwork.cs * Update ApexNetwork.cs * Networks project addition (#16) * upgrade nuget 1.1.7 to 1.1.9 and 4.0.0.57 and 4.0.0.58 * add NLog * added CoinbaseMaturity, PremineReward, pow reward, pos reward and max reorg for the apex network. * new project for ApexNetwork * remove APexD dependency in IntegrationTest * remove mainchainD and renamed apex to sidechainD (#19) OK * Nuget update (#21) * updated nuget packages * Replced ApiPort by GetApiPort from the FN * create custom node without asking for free api * added maxMoney and coinTicker * Networkz (#22) * using Apex throughout solution * removed unused assert method in Networks * remove left behind * remove extra space * Moved the FederatedPeg project into the FederationGateway project (#36) * Upgrade 1.1.11 to 1.1.12 (#42) * upgrade nuget 1.1.7 to 1.1.9 and 4.0.0.57 and 4.0.0.58 * add NLog * added CoinbaseMaturity, PremineReward, pow reward, pos reward and max reorg for the apex network. * Add new network properties to Apex * Update ApexNetwork.cs * Update ApexNetwork.cs * upgrade nuget packages * updated nuget packages (#48) * upgrade to dotnetcore 2.1, tests as libraries (#98) well done mate, that is awesome * Upgrade to fullnode 1.2.1 beta (#110) * Upgrade NBitcoin and as little dependencies as possible * Consolidate Stratis.Bitcoin * Upgrade all other Stratis and external packages * Trying to resolve genesis hash discrepancies in Apex * make sure all projects are in full debug mode, needed for code coverage analysis (#127) * upgrades libraries (#144) * upgrades to Stratis.Bitcoin.* 1.2.3-beta NStratis 4.0.0.67 Microsoft.NET.Test.Sdk 15.9.0 Xunit 2.4.1 That meant removing unused Integration test project which used corrupted Stratis.Bitcoin.IntegrationTests.Common temporarily * upgrade stratis packages to 1.2.4 and FluentAssertions to 5.5.3 (#181) * Adding a POA federated peg network (#182) * Adding a POA federated peg network Currently no smart contract packages so I have commented out the SC specifics ... * trying to get rid of Apex references * refactor network selector usaage I don't think we need 2 classes for that * no more need to instantiate a network to get its name * changes post review * Change Magic, Cointype and targetSpacingSeconds * add a "test" to run the different tools from within VisualStudio (#187) * add a "test" to run the different tools from within VisualStudio * Clear white spaces. * Federation Setup Console. (#189) * Add GenesisMiner and MultisigAddressCreator to console. Renamed console. * Changes after PR review. Changed switch values. Allow end user to select network. Allow end user to select quorum. * Quorum and Fed member argument validation. * Console OutputUsage update. * Reduced commandLineArgs in debug from 6 fed addresses down to 5. Removed actual keys from FederationSetup.OutputUsage(). MultisigAddressCreator now takes fed pubkeys from argument list not hard wired as before. Generating Fed pubkeys creates two lots. One for transfer of funds to sidechain and the other for sidechain mining. * Removed ReadLine() switch check. * Stratis packages upgrade 1.2.4 to 1.2.5 (#193) * Add locks and check that the federated wallet manager dealt with any forks (#202) * Add locks and check fedwalletmanager during forks * Reformat and reduce whitespace * Add missing waits * Back off if errors when send to counter node * Optimize performance by batching block data * Avoid large re-orgs * Add transaction serialization workaround to Initialize method * Upgrade packages * Adapted the console app to have a menu (#216) Changed the console app to have a menu rather than being a command line tool. The reason for that is that this utility is to be used by federation members and this change makes that easier. Also changed it so that it loops until the user exits  * Federation Setup tool - small improvements (#217) * Made Network non-optional Added text option to genesis block * Generate pubkeys properly, with file for migning priv key * Setup of FederatedPegTest (#221) * Use SmartContractPoAConsensusFactory for genesis block generation * No genesis reward for sidechains * Find (real) Genesis Block for FederatedPegTest * Increase Console input limit * Use RegTest for the local sidechain network * Add mining FedPubKeys and additional network fields * updtae to ports to be like Stratis+1 * Update FederatedPegTest.cs * premine reward back to 20 000 000 * Update FederatedPegTest.cs * upgrade fullnode from 1.2.6 to 1.2.7 (#236) * upgrade to release version of FullNode (#238) * upgrade to release version of FullNode 1.2.6-beta => 3.0.0.0 4.0.0.70 => 4.0.0.71 * remove stratis-dev nuget source * just to trigger a rebuild * Fixing codestyle issues (#253) * refactoring * edits * var for simple types * private and readonly * access modifiers * access modifier * fix codestyle violations part 2 (#256) * package upgrade to 3.0.0.0 to 3.0.0.1 (#257) * package upgrade to 3.0.0.0 to 3.0.0.1 add --no-build back to the script * fix FederatedPegBlockDefinition constructor * Refactored federation setup tool and added menue option to generate powershell script (#286) * Upgrade stratis nuget packages (#292) * NuGet update and Dbreeze serialization fix (#309) Allows the sidechains repo to serialize everything given the changes to the FN Dbreeze serialization and ultimately allows multiple nodes to run in the one process by removing static dependencies. I haven't actually connected to the network and completed a transfer yet - if someone could do that it would be ace. * add a arg for passphrase for multisig key derivation (#328) * add a arg for passphrase for multisig key derivation * place the passphrase correctly in the do not share section * FedPegMain definition (#343) * Moved coinbase text out of the CreateGenesis method * removed some unused variables * Brought the name and cointicker of the networks inline with the definition of the networks * Brought some more network data for Main inline * Upgrade # of coins to 100M * Create new genesis block for Main * updated to SBFN 3.0.0.4 beta (#355) * WPF Federation Key Generation App (#379) * Initial commit for fed setup GUI wizard in WPF Blend * POC for creating the keys with WPF and making sure we can have nugets working * Changes to FedKeyPairGen/Program.cs to allow to run it from command line Added Stratis logo on the top of the window and Statis icon * Add splash screen Add center window on startup * Added datadir argument to FederationSetup Removed redundent files from FederationApp * Changes to GUI to adopt it to consultancy website * First working version * Updated to displayed text, initial working version candidate * Added handling for pass phrase * Fixed name on the folder label * Removed POC projects * Removed unused left over build references for Xamarin * Updated FederationSetup.cs with help text for new args Cleaned up Program.cs and fixed exit SwitchCommand * Folders restructured * References fixed * Network values are updated. * Coinbase text updated. * Skipped tests removed.
fassadlr
pushed a commit
that referenced
this pull request
Jun 21, 2019
* Created FedKeyPairGen console app. Imported from Changeset 124 * Upgraded SBFN verison in project files. Imported from Changeset 150 * Moved Payload into feature Imported from Changeset 154 * Changed 'passphrase' in FedKeyPairGen to 'password'. Imported from Changeset 198 * Attempt to merge Enigma and EnigmaChain Imported from Changeset 201 * Updated the solution with the latest Stratis.Bitcoin nuget packages Imported from Changeset 202 * Removed name, folder and password from the pubkey generation as they are not required. The console app will simply show the user their mnemonic and the pubkey they need to share. * Removed mine premine stuff and added it to the FedKeyPairGen console app for now. * Remove custom env mockup helpers (#5) * created Apex definition * first bit of cleaning, all the mockup helpers have been removed as no special logic is needed to handle sidechains, they are just another network. Need to add back randomised API port attribution. Need to fix getCoinDetails test if it is being used by anyone (UI ?). The powershell command projects have been removed as they were only here to generate json files that have disappeared. * delete unused projects * Bring back FindPorts methods to later find a way to use it * Fix to get different API ports when creating multiple connected nodes on localhost, fix to GetCoinDetails, a bit basic for the moment, but we'll see how the code evolved * Put explanatory name on the Class in FederatedSidechains.Tests.Common * this doesn't work, somehow the constructor is called twice, and once with a null nodesettings, I need to investigate * Changes after PR comments * more merge changes ... * fix get-coindetails logic * Removed placeholder project and wrongly copied MainchainGeneratorService * consolidate .Net Sdk * added code to generate multisig in FedKeyPairGen (#8) * Jeremy's PR 14 reproduced with pr5 changes in (#15) * upgrade nuget 1.1.7 to 1.1.9 and 4.0.0.57 and 4.0.0.58 * add NLog * Add new network properties to Apex * Update ApexNetwork.cs * Update ApexNetwork.cs * Networks project addition (#16) * upgrade nuget 1.1.7 to 1.1.9 and 4.0.0.57 and 4.0.0.58 * add NLog * added CoinbaseMaturity, PremineReward, pow reward, pos reward and max reorg for the apex network. * new project for ApexNetwork * remove APexD dependency in IntegrationTest * remove mainchainD and renamed apex to sidechainD (#19) OK * Nuget update (#21) * updated nuget packages * Replced ApiPort by GetApiPort from the FN * create custom node without asking for free api * added maxMoney and coinTicker * Networkz (#22) * using Apex throughout solution * removed unused assert method in Networks * remove left behind * remove extra space * Moved the FederatedPeg project into the FederationGateway project (#36) * Upgrade 1.1.11 to 1.1.12 (#42) * upgrade nuget 1.1.7 to 1.1.9 and 4.0.0.57 and 4.0.0.58 * add NLog * added CoinbaseMaturity, PremineReward, pow reward, pos reward and max reorg for the apex network. * Add new network properties to Apex * Update ApexNetwork.cs * Update ApexNetwork.cs * upgrade nuget packages * updated nuget packages (#48) * upgrade to dotnetcore 2.1, tests as libraries (#98) well done mate, that is awesome * Upgrade to fullnode 1.2.1 beta (#110) * Upgrade NBitcoin and as little dependencies as possible * Consolidate Stratis.Bitcoin * Upgrade all other Stratis and external packages * Trying to resolve genesis hash discrepancies in Apex * make sure all projects are in full debug mode, needed for code coverage analysis (#127) * upgrades libraries (#144) * upgrades to Stratis.Bitcoin.* 1.2.3-beta NStratis 4.0.0.67 Microsoft.NET.Test.Sdk 15.9.0 Xunit 2.4.1 That meant removing unused Integration test project which used corrupted Stratis.Bitcoin.IntegrationTests.Common temporarily * upgrade stratis packages to 1.2.4 and FluentAssertions to 5.5.3 (#181) * Adding a POA federated peg network (#182) * Adding a POA federated peg network Currently no smart contract packages so I have commented out the SC specifics ... * trying to get rid of Apex references * refactor network selector usaage I don't think we need 2 classes for that * no more need to instantiate a network to get its name * changes post review * Change Magic, Cointype and targetSpacingSeconds * add a "test" to run the different tools from within VisualStudio (#187) * add a "test" to run the different tools from within VisualStudio * Clear white spaces. * Federation Setup Console. (#189) * Add GenesisMiner and MultisigAddressCreator to console. Renamed console. * Changes after PR review. Changed switch values. Allow end user to select network. Allow end user to select quorum. * Quorum and Fed member argument validation. * Console OutputUsage update. * Reduced commandLineArgs in debug from 6 fed addresses down to 5. Removed actual keys from FederationSetup.OutputUsage(). MultisigAddressCreator now takes fed pubkeys from argument list not hard wired as before. Generating Fed pubkeys creates two lots. One for transfer of funds to sidechain and the other for sidechain mining. * Removed ReadLine() switch check. * Stratis packages upgrade 1.2.4 to 1.2.5 (#193) * Add locks and check that the federated wallet manager dealt with any forks (#202) * Add locks and check fedwalletmanager during forks * Reformat and reduce whitespace * Add missing waits * Back off if errors when send to counter node * Optimize performance by batching block data * Avoid large re-orgs * Add transaction serialization workaround to Initialize method * Upgrade packages * Adapted the console app to have a menu (#216) Changed the console app to have a menu rather than being a command line tool. The reason for that is that this utility is to be used by federation members and this change makes that easier. Also changed it so that it loops until the user exits  * Federation Setup tool - small improvements (#217) * Made Network non-optional Added text option to genesis block * Generate pubkeys properly, with file for migning priv key * Setup of FederatedPegTest (#221) * Use SmartContractPoAConsensusFactory for genesis block generation * No genesis reward for sidechains * Find (real) Genesis Block for FederatedPegTest * Increase Console input limit * Use RegTest for the local sidechain network * Add mining FedPubKeys and additional network fields * updtae to ports to be like Stratis+1 * Update FederatedPegTest.cs * premine reward back to 20 000 000 * Update FederatedPegTest.cs * upgrade fullnode from 1.2.6 to 1.2.7 (#236) * upgrade to release version of FullNode (#238) * upgrade to release version of FullNode 1.2.6-beta => 3.0.0.0 4.0.0.70 => 4.0.0.71 * remove stratis-dev nuget source * just to trigger a rebuild * Fixing codestyle issues (#253) * refactoring * edits * var for simple types * private and readonly * access modifiers * access modifier * fix codestyle violations part 2 (#256) * package upgrade to 3.0.0.0 to 3.0.0.1 (#257) * package upgrade to 3.0.0.0 to 3.0.0.1 add --no-build back to the script * fix FederatedPegBlockDefinition constructor * Refactored federation setup tool and added menue option to generate powershell script (#286) * Upgrade stratis nuget packages (#292) * NuGet update and Dbreeze serialization fix (#309) Allows the sidechains repo to serialize everything given the changes to the FN Dbreeze serialization and ultimately allows multiple nodes to run in the one process by removing static dependencies. I haven't actually connected to the network and completed a transfer yet - if someone could do that it would be ace. * add a arg for passphrase for multisig key derivation (#328) * add a arg for passphrase for multisig key derivation * place the passphrase correctly in the do not share section * FedPegMain definition (#343) * Moved coinbase text out of the CreateGenesis method * removed some unused variables * Brought the name and cointicker of the networks inline with the definition of the networks * Brought some more network data for Main inline * Upgrade # of coins to 100M * Create new genesis block for Main * updated to SBFN 3.0.0.4 beta (#355) * WPF Federation Key Generation App (#379) * Initial commit for fed setup GUI wizard in WPF Blend * POC for creating the keys with WPF and making sure we can have nugets working * Changes to FedKeyPairGen/Program.cs to allow to run it from command line Added Stratis logo on the top of the window and Statis icon * Add splash screen Add center window on startup * Added datadir argument to FederationSetup Removed redundent files from FederationApp * Changes to GUI to adopt it to consultancy website * First working version * Updated to displayed text, initial working version candidate * Added handling for pass phrase * Fixed name on the folder label * Removed POC projects * Removed unused left over build references for Xamarin * Updated FederationSetup.cs with help text for new args Cleaned up Program.cs and fixed exit SwitchCommand * Folders restructured * References fixed * Network values are updated. * Coinbase text updated. * Skipped tests removed.
dangershony
added a commit
to dangershony/StratisBitcoinFullNode
that referenced
this pull request
Nov 17, 2019
codingupastorm
added a commit
to codingupastorm/StratisBitcoinFullNode
that referenced
this pull request
Dec 15, 2019
Implement the TokenlessCoinview Rule
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.