Resolved warnings

Stratis.Bitcoin.Common/JsonErrors/ErrorResult.cs

@@ -6,7 +6,7 @@ public class ErrorResult : ObjectResult
     {
 	    public ErrorResult(int statusCode, ErrorResponse value) : base(value)
 	    {
-			StatusCode = statusCode;
+			this.StatusCode = statusCode;
 		}
 	}
 }

Stratis.Bitcoin.Common/Stratis.Bitcoin.Common.csproj

@@ -4,6 +4,10 @@
     <TargetFramework>netstandard1.6</TargetFramework>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
+    <NoWarn>1701;1702;1705;IDE0008;</NoWarn>
+  </PropertyGroup>
+
   <ItemGroup>
     <PackageReference Include="Microsoft.AspNetCore" Version="1.1.2" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc.Abstractions" Version="1.1.3" />

Stratis.Bitcoin.IntegrationTests/BlockStoreTests.cs

@@ -17,7 +17,7 @@ namespace Stratis.Bitcoin.IntegrationTests
     public class BlockStoreTests
     {
 
-		//[Fact]
+		// [Fact]
 		public void BlockRepositoryBench()
 		{
 			using (var dir = TestDirectory.Create())

Stratis.Bitcoin.IntegrationTests/ChainBuilder.cs

@@ -17,18 +17,18 @@ public class ChainBuilder
 		public ChainBuilder(Network network)
 		{
 			Guard.NotNull(network, nameof(network));
-			
-			_Network = network;
-			_Chain = new ConcurrentChain(_Network);
-			MinerKey = new Key();
-			MinerScriptPubKey = MinerKey.PubKey.Hash.ScriptPubKey;
+
+            this._Network = network;
+            this._Chain = new ConcurrentChain(this._Network);
+			this.MinerKey = new Key();
+            this.MinerScriptPubKey = this.MinerKey.PubKey.Hash.ScriptPubKey;
 		}
 
 		public ConcurrentChain Chain
 		{
 			get
 			{
-				return _Chain;
+				return this._Chain;
 			}
 		}
 
@@ -47,24 +47,24 @@ public Transaction Spend(ICoin[] coins, Money amount)
 		{
 			TransactionBuilder builder = new TransactionBuilder();
 			builder.AddCoins(coins);
-			builder.AddKeys(MinerKey);
-			builder.Send(MinerScriptPubKey, amount);
+			builder.AddKeys(this.MinerKey);
+			builder.Send(this.MinerScriptPubKey, amount);
 			builder.SendFees(Money.Coins(0.01m));
-			builder.SetChange(MinerScriptPubKey);
+			builder.SetChange(this.MinerScriptPubKey);
 			var tx = builder.BuildTransaction(true);
 			return tx;
 		}
 
 		public ICoin[] GetSpendableCoins()
 		{
-			return _Blocks
+			return this._Blocks
 				.Select(b => b.Value)
 				.SelectMany(b => b.Transactions.Select(t => new
 				{
 					Tx = t,
 					Block = b
 				}))
-				.Where(b => !b.Tx.IsCoinBase || (_Chain.Height + 1) - _Chain.GetBlock(b.Block.GetHash()).Height >= 100)
+				.Where(b => !b.Tx.IsCoinBase || (this._Chain.Height + 1) - this._Chain.GetBlock(b.Block.GetHash()).Height >= 100)
 				.Select(b => b.Tx)
 				.SelectMany(b => b.Outputs.AsIndexedOutputs())
 				.Where(o => o.TxOut.ScriptPubKey == this.MinerScriptPubKey)
@@ -80,14 +80,14 @@ public void Mine(int blockCount)
 			{
 				uint nonce = 0;
 				Block block = new Block();
-				block.Header.HashPrevBlock = _Chain.Tip.HashBlock;
-				block.Header.Bits = block.Header.GetWorkRequired(_Network, _Chain.Tip);
-				block.Header.UpdateTime(now, _Network, _Chain.Tip);
+				block.Header.HashPrevBlock = this._Chain.Tip.HashBlock;
+				block.Header.Bits = block.Header.GetWorkRequired(this._Network, this._Chain.Tip);
+				block.Header.UpdateTime(now, this._Network, this._Chain.Tip);
 				var coinbase = new Transaction();
-				coinbase.AddInput(TxIn.CreateCoinbase(_Chain.Height + 1));
-				coinbase.AddOutput(new TxOut(_Network.GetReward(_Chain.Height + 1), MinerScriptPubKey));
+				coinbase.AddInput(TxIn.CreateCoinbase(this._Chain.Height + 1));
+				coinbase.AddOutput(new TxOut(this._Network.GetReward(this._Chain.Height + 1), this.MinerScriptPubKey));
 				block.AddTransaction(coinbase);
-				foreach(var tx in _Transactions)
+				foreach(var tx in this._Transactions)
 				{
 					block.AddTransaction(tx);
 				}
@@ -96,21 +96,21 @@ public void Mine(int blockCount)
 					block.Header.Nonce = ++nonce;
 				block.Header.CacheHashes();
 				blocks.Add(block);
-				_Transactions.Clear();
-				_Chain.SetTip(block.Header);
+				this._Transactions.Clear();
+                this._Chain.SetTip(block.Header);
 			}
 
 			foreach(var b in blocks)
 			{
-				_Blocks.Add(b.GetHash(), b);
+                this._Blocks.Add(b.GetHash(), b);
 			}
 		}
 
 		internal Dictionary<uint256, Block> _Blocks = new Dictionary<uint256, Block>();
 		private List<Transaction> _Transactions = new List<Transaction>();
 		public void Broadcast(Transaction tx)
 		{
-			_Transactions.Add(tx);
+            this._Transactions.Add(tx);
 		}
 	}
 }

Stratis.Bitcoin.IntegrationTests/CoinViewTester.cs

@@ -17,7 +17,7 @@ public class SpendableCoin
 		public CoinViewTester(CoinView coinView)
 		{
 			this.coinView = coinView;
-			_Hash = coinView.GetBlockHashAsync().Result;
+            this._Hash = coinView.GetBlockHashAsync().Result;
 		}
 
 		List<UnspentOutputs> _PendingCoins = new List<UnspentOutputs>();
@@ -28,14 +28,14 @@ public Coin[] CreateCoins(int coinCount)
 							.Select(t => new TxOut(Money.Zero, new Key()))
 							.ToArray());
 			var output = new UnspentOutputs(1, tx);
-			_PendingCoins.Add(output);
+            this._PendingCoins.Add(output);
 			return tx.Outputs.AsCoins().ToArray();
 		}
 
 		public bool Exists(Coin c)
 		{
-			var result = coinView.FetchCoinsAsync(new[] { c.Outpoint.Hash }).Result;
-			if(result.BlockHash != _Hash)
+			var result = this.coinView.FetchCoinsAsync(new[] { c.Outpoint.Hash }).Result;
+			if(result.BlockHash != this._Hash)
 				throw new InvalidOperationException("Unexepected hash");
 			if(result.UnspentOutputs[0] == null)
 				return false;
@@ -44,18 +44,18 @@ public bool Exists(Coin c)
 
 		public void Spend(Coin c)
 		{
-			var coin = _PendingCoins.FirstOrDefault(u => u.TransactionId == c.Outpoint.Hash);
+			var coin = this._PendingCoins.FirstOrDefault(u => u.TransactionId == c.Outpoint.Hash);
 			if(coin == null)
 			{
-				var result = coinView.FetchCoinsAsync(new[] { c.Outpoint.Hash }).Result;
-				if(result.BlockHash != _Hash)
+				var result = this.coinView.FetchCoinsAsync(new[] { c.Outpoint.Hash }).Result;
+				if(result.BlockHash != this._Hash)
 					throw new InvalidOperationException("Unexepected hash");
 				if(result.UnspentOutputs[0] == null)
 					throw new InvalidOperationException("Coin unavailable");
 
 				if(!result.UnspentOutputs[0].Spend(c.Outpoint.N))
 					throw new InvalidOperationException("Coin unspendable");
-				_PendingCoins.Add(result.UnspentOutputs[0]);
+                this._PendingCoins.Add(result.UnspentOutputs[0]);
 			}
 			else
 			{
@@ -68,16 +68,16 @@ public void Spend(Coin c)
 		public uint256 NewBlock()
 		{
 			var newHash = new uint256(RandomUtils.GetBytes(32));
-			coinView.SaveChangesAsync(_PendingCoins, null, _Hash, newHash).Wait();
-			_PendingCoins.Clear();
-			_Hash = newHash;
+			this.coinView.SaveChangesAsync(this._PendingCoins, null, this._Hash, newHash).Wait();
+			this._PendingCoins.Clear();
+            this._Hash = newHash;
 			return newHash;
 		}
 
 		public uint256 Rewind()
 		{
-			_Hash = coinView.Rewind().Result;
-			return _Hash;
+            this._Hash = this.coinView.Rewind().Result;
+			return this._Hash;
 		}
 	}
 }