This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
Introduce WalletAccountReference type #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasDorier
force-pushed
the
walletaccountref
branch
3 times, most recently
from
18a5481 to
d387b09
Compare
NicolasDorier
force-pushed
the
walletaccountref
branch
from
d387b09 to
b7785f3
Compare
dangershony
approved these changes
Jul 13, 2017
| { | ||
| //TODO: Support multi wallet like core by mapping passed RPC credentials to a wallet/account |
There was a problem hiding this comment.
An option is pass to the RPC a wallet and accoumt names and if null default to first()
There was a problem hiding this comment.
The goal of RPC controller is to be compatible with what has been developped for core. Else I would use WalletController
Core is using RPC creds for mapping to right wallet.
codingupastorm
pushed a commit
to codingupastorm/StratisBitcoinFullNode
that referenced
this pull request
Mar 4, 2020
…ng-mining-tests [Cleanup] Remove obvious staking and mining tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pair accountname and walletname will often travel together, this make sense to create a value object to bundle them together instead of passing them as individual string.