Clean up tabbing and warnings in mempool feature. #311
Conversation
In prep for refactoring.
There was a problem hiding this comment.
Thanks for taking care of that.
Do you mind giving me a bit of context as to why you've commented some bits of code?
Also please for next time, don't mix changes of spacing and actual changes in the code in the same commit, as it's very hard to spot in a review :-)
| // from. pfrom->AskFor(_inv); | ||
| } | ||
| var ret = await this.AddOrphanTx(from.PeerVersion.Nonce, tx); | ||
| //int nFetchFlags = 0; //GetFetchFlags(pfrom, chainActive.Tip(), chainparams.GetConsensus()); |
There was a problem hiding this comment.
is this not used anywhere?
| // TODO: Implement Later with CheckRateLimit() | ||
| //private readonly FreeLimiterSection freeLimiter; | ||
|
|
||
| //private class FreeLimiterSection |
There was a problem hiding this comment.
is this not used anywhere either?
| public PowConsensusOptions ConsensusOptions => this.consensusValidator.ConsensusOptions; | ||
| public static readonly FeeRate MinRelayTxFee = new FeeRate(DefaultMinRelayTxFee); | ||
| // TODO: Implement Later with CheckRateLimit() | ||
| //private readonly FreeLimiterSection freeLimiter; |
| } | ||
| } | ||
|
|
||
| private void Chec |
There was a problem hiding this comment.
why did this get commented?
|
Yes the only changes were commenting out some code that wasn't used anywhere that was throwing up a couple of compiler warnings. It compiles clean now. |
|
Lovely stuff, thank you :-) |
|
you can remove it completely, the GetFetchFlags doesn't even exist. |
|
Thank you Mike :-) @mikedennis |
Goes in after #309. Sets up 2 chains. Mines coins on main chain. Sends to sidechain via federation. Verifies that coins are received on sidechain. Much to expand on from here.
…-policy Set policy that goes into create transactions
In prep for refactoring.