-
Notifications
You must be signed in to change notification settings - Fork 312
[Swagger] Create Branding #3652
base: master
Are you sure you want to change the base?
Conversation
Nice. |
@@ -97,6 +98,12 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerF | |||
|
|||
app.UseCors("CorsPolicy"); | |||
|
|||
app.UseStaticFiles(new StaticFileOptions | |||
{ | |||
FileProvider = new PhysicalFileProvider(@"C:\Users\me\Stratis\StratisBitcoinFullNode\src\Stratis.Bitcoin.Features.Api\wwwroot\"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need some help to found the Stratis.Bitcoin.Features.Api
folder programatically, but for now I add it as raw string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally done in bc0580a
Important thing: The feature So I added a copy feature in the .csproj of <ItemGroup>
<Content Update="wwwroot\**\*.*">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</Content>
</ItemGroup> My question is, does this will be a problem ? and also if I rename the |
About the Stratis Color codes, can have some precisions, I don't know if the color that I use is the good. Fixed f8d062a |
Another point: Maybe we can display an information on the swagger about the network that is ran, if it's bitcoin network, stratis network etc I said this because when I launch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clintnetwork top of the page looks great, but bottom part little bit confused me. @noescape00 what do you think? |
Yes yes, you right, the try out design is not finished, for now its less readable it's true. In fact I made this PR to have a base and discuss about the direction to take. 👍 |
@kogot I agree with you. |
Way better now from a readability perspective. Is it the final version? |
No no, we had some ideas with @dangershony to create a multipages swagger with an embedded wallet maybe or other features. I also opened this PR to brainstorm about that. |
@clintnetwork multipage can be done in following PRs, if you find a good stable swagger customized UI I say we can consider pushing it. |
…o access to this assets
I create a |
I had an old dashboard project for stratis and I was using EmbeddedFileProvider but a lot of time passed (more than 2 years!) here what kind of problem did you have? try to take a look at the code if it may help you, otherwise I'll try to remember how I was using it |
Ha nice @MithrilMan just trying to use |
@clintnetwork ok if I'll find the time I'll try that |
@MithrilMan are you on the slack ? |
Make a Swagger Branding
The idea is to have a custom Swagger with some branding details / style.