This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
[BlockStore] ProcessPendingStorage should download and persist new blocks immediately #392 #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangershony
suggested changes
Sep 4, 2017
|
|
||
| ChainedBlock lastFoundChainedBlock = nextChainedBlock; | ||
| //If pending storage has not yet reached the threshold or the node is in IDB, stop the loop and wait for more blocks. | ||
| if (this.BlockStoreLoop.PendingStorage.Count < BlockStoreLoop.PendingStorageBatchThreshold && this.BlockStoreLoop.ChainState.IsInitialBlockDownload == true) |
There was a problem hiding this comment.
You can swap this so first check for IBD, to avoid enumerating the list.
Also need to take the dispose property in to account(i.e. if in dispose more then just push).
| if (context.PendingBlockPairsToStore.Any()) | ||
| { | ||
| this.logger.LogTrace("[FLUSH_NEXTBLOCKNOTINPENDING]", nameof(context.PendingStorageBatchSize), context.PendingStorageBatchSize); | ||
| await PushBlocksToRepository(context); |
| } | ||
|
|
||
| if ((pendingStorageBatchSize > BlockStoreLoop.MaxPendingInsertBlockSize) || breakExecution) | ||
| if (context.PendingStorageBatchSize > BlockStoreLoop.MaxPendingInsertBlockSize) |
There was a problem hiding this comment.
What about the 'dispose' propertry
codingupastorm
pushed a commit
to codingupastorm/StratisBitcoinFullNode
that referenced
this pull request
Jul 8, 2020
Rename Bitcoin.Peer to Core.Peer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.