This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
[FN] Additional handling for malformed peers.json #4192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have carefully re-reviewed the logic around peer discovery; I do not actually see how a node with acceptable network connectivity can remain without peers for an extended period even if the
peers.json
somehow got corrupted.Nevertheless, this traps for any exceptions (if the deserialisation of the JSON happens to throw any - this is somewhat doubtful), and initialises an empty list if the deserialised object is ever
null
.The expected behaviour if this occurs is that the
PeerDiscoveryLoop
will in any case run almost immediately after startup and determine that there are no known peers. It will then add the DNS seeds & seed nodes as discovery candidates, which should elicit some connectable peers.