This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
Add a node setting to control use of checkpoints. #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aprogiena
reviewed
Nov 5, 2017
| { | ||
| if (network.Equals(Network.Main)) this.checkpoints = bitcoinMainnetCheckpoints; | ||
| if (settings != null && !settings.UseCheckpoints) this.checkpoints = new Dictionary<int, CheckpointInfo>(); |
There was a problem hiding this comment.
if you want to make me happy, pls use parentheses like this if ((settings != null) && !settings.UseCheckpoints) - i.e. use them even if not needed, so that one does not need to know the operator priority
fassadlr
pushed a commit
to fassadlr/StratisBitcoinFullNode
that referenced
this pull request
Nov 20, 2017
* Add a node setting to control use of checkpoints. stratisproject#476 * Address some code review issues. * Fix build issue.
rowandh
pushed a commit
to rowandh/StratisBitcoinFullNode
that referenced
this pull request
May 14, 2018
- Renames GetFileDllHelper to SmartContractCompiler - Add SmartContractCompilationResult - Cleans up and unifies list of allowed assemblies in a Smart Contract - Update tests Related work items: stratisproject#701
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address issue #476