Fix/ST-43: Bug fix #348
Merged
Fix/ST-43: Bug fix #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rest Add add: RewardsByWalletAndHeight, RewardsByWalletAndEpoch
BoThe1K
reviewed
Mar 12, 2024
| } | ||
|
|
||
| rpc CirculationSupply(QueryCirculationSupplyRequest) returns (QueryCirculationSupplyResponse) { | ||
| option (google.api.http).get = "/stratos/pot/v1/circulation-supply"; | ||
| option (google.api.http).get = "/stratos/pot/v1/circulation_supply"; |
There was a problem hiding this comment.
@Xiong-stratos What context to change to _? If it is agreed, you should also fix in big-dipper for these changes.
There was a problem hiding this comment.
Some of our query url are using "-", and some are using "_"。
The style of query url is Inconsistent.
Big-dipper only query the metrix, doesn't call any other query APIs.
There was a problem hiding this comment.
@Xiong-stratos I think the big dipper metrics where calculate the APY used this api
alexstratos
previously approved these changes
Mar 15, 2024
alexstratos
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query API:
-- Rename: RewardsByOwner -> RewardsByWallet
-- Add: RewardsByWalletAndEpoch
-- Update: Use "_" instead of "-" in Rest API Urls to follow the pattern of cosmos-sdk
-- Bug fix
Genesis:
-- Add KickMetaNodeVotePool