Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add google map component #5

Open
stratospark opened this issue Oct 22, 2014 · 4 comments
Open

add google map component #5

stratospark opened this issue Oct 22, 2014 · 4 comments
Assignees

Comments

@stratospark
Copy link
Owner

No description provided.

@stratospark stratospark self-assigned this Oct 22, 2014
@stratospark
Copy link
Owner Author

I'm trying leaflet first. It seems to require some server-side integration to make it work. I've pushed a branch here: https://github.com/stratospark/react-ss/tree/maps

@stratospark
Copy link
Owner Author

Got Leaflet to work on the client side and placeholder rendered for server-side. Currently, it breaks if you switch away from the page.

@igaltivoni In your Plentyhood app, do you ever re-render the map? Is there ever a situation where you go to a view without a map then go back to a view with a map?

image

@igal1c0de4n
Copy link
Collaborator

In Plentyhood.com you can switch between the map view and the splash
screen. Every time you go to the page which has leaflet, the map is
re-rendered.

Is this what you asked?

On Mon, Oct 27, 2014 at 8:30 PM, Patrick Rodriguez <notifications@github.com

wrote:

Got Leaflet to work on the client side and placeholder rendered for
server-side. Currently, it breaks if you switch away from the page.

@igaltivoni https://github.com/igaltivoni In your Plentyhood app, do
you ever re-render the map? Is there ever a situation where you go to a
view without a map then go back to a view with a map?

[image: image]
https://cloud.githubusercontent.com/assets/93366/4803157/88d96aa6-5e52-11e4-82f1-b8a4b6e6f992.png


Reply to this email directly or view it on GitHub
#5 (comment).

@stratospark
Copy link
Owner Author

Yes. Was wondering if you cached the map object somewhere else and
reattached it when it became visible again. Probably premature optimization.

On Monday, October 27, 2014, igal notifications@github.com wrote:

In Plentyhood.com you can switch between the map view and the splash
screen. Every time you go to the page which has leaflet, the map is
re-rendered.

Is this what you asked?

On Mon, Oct 27, 2014 at 8:30 PM, Patrick Rodriguez <
notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');

wrote:

Got Leaflet to work on the client side and placeholder rendered for
server-side. Currently, it breaks if you switch away from the page.

@igaltivoni https://github.com/igaltivoni In your Plentyhood app, do
you ever re-render the map? Is there ever a situation where you go to a
view without a map then go back to a view with a map?

[image: image]
<
https://cloud.githubusercontent.com/assets/93366/4803157/88d96aa6-5e52-11e4-82f1-b8a4b6e6f992.png>


Reply to this email directly or view it on GitHub
#5 (comment).


Reply to this email directly or view it on GitHub
#5 (comment).

-pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants