Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix parse dhcp log header #23

Merged
merged 3 commits into from
May 21, 2023
Merged

Conversation

verovaleros
Copy link
Member

@verovaleros verovaleros commented May 21, 2023

Description

The dhcp.log contains a different header. Instead of uid contains uids. This caused the column not to be parsed properly and, therefore, to generate an empty labelled file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Run locally the zeek-files-labeler.py on a zeek folder
  • Manually verified the output is correct

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@verovaleros verovaleros added the enhancement New feature or request label May 21, 2023
@verovaleros verovaleros added this to the v1.0.0 milestone May 21, 2023
@verovaleros verovaleros requested a review from eldraco May 21, 2023 10:18
@verovaleros verovaleros self-assigned this May 21, 2023
@verovaleros
Copy link
Member Author

I talked about the changes in-person with the assigned reviewer.

@verovaleros verovaleros merged commit c47d0e1 into main May 21, 2023
@verovaleros verovaleros deleted the bugfix_parse-dhcp-log-header branch May 21, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant