Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code improvements to zeek-files-labeler #25

Merged
merged 25 commits into from
May 21, 2023
Merged

Code improvements to zeek-files-labeler #25

merged 25 commits into from
May 21, 2023

Conversation

verovaleros
Copy link
Member

@verovaleros verovaleros commented May 21, 2023 •
edited
Loading

Description

Addressed most issues highlighted by Pylint (except for the Too many warnings).

Type of change

  • Code fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Run the zeek-files-labeler on several captures
  • Manually verified the output is consistent and correct

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

verovaleros added 23 commits May 21, 2023 13:28
@verovaleros
Improve cache_labeled_file() docstrings
5295775
@verovaleros
Improve define_type docstrings
fc4410c
@verovaleros
Improve comments on define_type()
bbd5e87
@verovaleros
Return input_type for all cases
02ea9ce
@verovaleros
Raise exception if no type is found
3bd5c96
@verovaleros
Improve output_netflow_line_to_file docstrings
48e99c8
@verovaleros
Improve output_netflow_line_to_file comments
6cd3c10
@verovaleros
Improve output_netflow_line_to_file docstrings
e4985f1
@verovaleros
Improve define_columns docstrings
e200358
@verovaleros
Improve code readability
fbeeae4
@verovaleros
Improve tool description
185715e
@verovaleros
Fix C0325 unnecessary parens on while statement
752aab4
@verovaleros
Use isinstance() rather than type() for a typecheck
a9fbbc3
@verovaleros
Better handling of undefined logs type
f52da41
@verovaleros
Fix W1514 unspecified-encoding
78ef280
@verovaleros
Use f' on prints no .format()
1de3d73
@verovaleros
Remove unused variable
a73f59a
@verovaleros
Raise exception if subprocess fails
ffdea4d
@verovaleros
Remove unnecessary pass
d93f0e0
@verovaleros
Remove unused variable
cf0b57f
@verovaleros
Merged comparisons with 'in'
b8aba1e
@verovaleros
Better parsing of columns
e359277
@verovaleros
add main docstring
a96d010
@verovaleros verovaleros added the enhancement New feature or request label May 21, 2023
@verovaleros verovaleros added this to the v1.0.0 milestone May 21, 2023
@verovaleros verovaleros self-assigned this May 21, 2023
@verovaleros verovaleros merged commit 417afe1 into main May 21, 2023
@verovaleros verovaleros deleted the feat_zeek-files-labeler-improvements branch May 21, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@verovaleros verovaleros

Labels
enhancement New feature or request
Projects
Netflow Labeler
Status: ✅ Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@verovaleros