Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement - get Cognito userPoolClientSecret directly from the UserPoolClient #169

Closed
giuliopulina opened this issue Dec 13, 2022 · 1 comment
Closed

Improvement - get Cognito userPoolClientSecret directly from the UserPoolClient #169

giuliopulina opened this issue Dec 13, 2022 · 1 comment
Assignees
@BjoernKW
Labels
application-feedback Bugs or anything else to improve the sample Todo application refactoring Improvements regarding code design or structure

Comments

@giuliopulina
Copy link

giuliopulina commented Dec 13, 2022 •
edited
Loading

What's going wrong and not working?

Starting from AWS CDK 2.37.0, it is possible to get the client secret of a UserPoolClient directly, using the following method call that returns a SecretValue:

userPoolClient.getUserPoolClientSecret()

So the workaround using describeUserPoolClient is not needed anymore.

Expected outcome

No response
@giuliopulina giuliopulina added application-feedback Bugs or anything else to improve the sample Todo application triage Waiting on feedback from the maintainers labels Dec 13, 2022
@giuliopulina giuliopulina changed the title Improvement - get Cognito userPoolClientSecret directly from the UserPool Improvement - get Cognito userPoolClientSecret directly from the UserPoolClient Dec 13, 2022
BjoernKW added a commit that referenced this issue Jan 30, 2023
@BjoernKW
#169
ce493a3
@BjoernKW BjoernKW added refactoring Improvements regarding code design or structure and removed triage Waiting on feedback from the maintainers labels Jan 30, 2023
@BjoernKW BjoernKW mentioned this issue Jan 30, 2023
Merged
@BjoernKW
Copy link
Contributor

Thanks a lot for the feedback! We'll fix this in the next release and change the text in the ebook accordingly

@BjoernKW BjoernKW self-assigned this Jan 30, 2023
BjoernKW added a commit that referenced this issue Feb 6, 2023
@BjoernKW
Merge pull request #184 from stratospheric-dev/improvement/get_Cognit…
1526040 
…o_userPoolClientSecret_directly_from_the_UserPoolClient-169

#169
@BjoernKW BjoernKW closed this as completed Feb 6, 2023
BjoernKW added a commit that referenced this issue Aug 27, 2023
@BjoernKW
#169
1f8a840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BjoernKW BjoernKW

Labels
application-feedback Bugs or anything else to improve the sample Todo application refactoring Improvements regarding code design or structure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BjoernKW @giuliopulina