Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Roles as a prepration for integration tests #1093

Open
5 of 6 tasks
Tracked by #1120 ...
jbesraa opened this issue Aug 13, 2024 · 4 comments · Fixed by #1092, #1095 or #1097
Open
5 of 6 tasks
Tracked by #1120 ...

Restructure Roles as a prepration for integration tests #1093

jbesraa opened this issue Aug 13, 2024 · 4 comments · Fixed by #1092, #1095 or #1097
Assignees
Milestone

Comments

@jbesraa
Copy link
Contributor

jbesraa commented Aug 13, 2024

This is the first stage of #1120

While trying to add integration tests we noticed that the roles logic should have a bit of refactor, mainly moving some of the library logic out of main.rs to lib folder/file in order to make it nicely accessible via testing.

Currently we have four different roles we want to refactor

Example for such change covering the Translator role https://github.com/stratum-mining/stratum/pull/1092/files

Goals:

  • Get the roles code structured in a way that they can be composable inside the new integration test framework.
  • Avoid breaking current behavior of roles. After this refactoring, it’s important that all roles continue passing the current MG test stack, and can also be launched manually while following the expected behavior.
@plebhash plebhash changed the title Refactor Roles as a prepration for integration tests Restrutuce Roles as a prepration for integration tests Aug 19, 2024
@plebhash plebhash changed the title Restrutuce Roles as a prepration for integration tests Restructure Roles as a prepration for integration tests Aug 19, 2024
@plebhash plebhash added this to the 1.1.0 milestone Aug 20, 2024
@plebhash plebhash self-assigned this Aug 20, 2024
@plebhash

This comment has been minimized.

@jbesraa
Copy link
Contributor Author

jbesraa commented Sep 12, 2024

Added MiningDevice to the list above and a corresponding PR

Edit: not sure if it should be part of this list actually

@GitGab19
Copy link
Collaborator

Can we close this issue now that #1163 has been merged? @jbesraa @plebhash

@jbesraa
Copy link
Contributor Author

jbesraa commented Sep 30, 2024

Can we close this issue now that #1163 has been merged? @jbesraa @plebhash

Yup all done here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment