Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove async_std support #1402

Open
plebhash opened this issue Jan 27, 2025 · 6 comments · Fixed by #1423 or #1424 · May be fixed by #1433
Open

remove async_std support #1402

plebhash opened this issue Jan 27, 2025 · 6 comments · Fixed by #1423 or #1424 · May be fixed by #1433
Assignees
@Shourya742
Labels
async refactor Implies refactoring code roles Pertains to all roles
Milestone
1.3.0

Comments

@plebhash
Copy link
Collaborator

plebhash commented Jan 27, 2025 •
edited
Loading

maintaining support for async_std in SRI substantially increases the engineering efforts

meanwhile, the SRI application layer is built with tokio, which is already quite challenging to maintain

therefore, we should drop the async_std support to make things simpler and cleaner, and most importantly: something that allows our limited engineering resources to sustainably achieve production readiness

SRI application layer (roles, network_helpers_sv2, integration_tests_sv2) should only officially support tokio
@plebhash
Copy link
Collaborator Author

plebhash commented Jan 27, 2025 •
edited
Loading

related:

issues:

PRs:

@plebhash plebhash mentioned this issue Jan 27, 2025
Merged
@plebhash plebhash added refactor Implies refactoring code roles Pertains to all roles async labels Jan 27, 2025
@plebhash plebhash mentioned this issue Jan 27, 2025
Merged
@plebhash
Copy link
Collaborator Author

plebhash commented Jan 27, 2025 •
edited
Loading

cc @Fi3 pinging you so you're aware

does Demand heavily rely on anything async_std?

@Fi3
Copy link
Collaborator

Fi3 commented Jan 28, 2025

cc @Fi3 pinging you so you're aware

does Demand heavily rely on anything async_std?

no we use only tokio

This was referenced Jan 30, 2025
Merged
Merged
@plebhash
Copy link
Collaborator Author

plebhash commented Feb 1, 2025

re-opening, as we still have some left-overs:

  • network_helpers_sv2 has async_std modules
  • benches makes use of network_helpers_sv2 on async_std mode

I'll send a follow-up PR soon

@plebhash plebhash reopened this Feb 1, 2025
@plebhash plebhash added this to the 1.3.0 milestone Feb 1, 2025
@Shourya742
Copy link
Contributor

re-opening, as we still have some left-overs:

  • network_helpers_sv2 has async_std modules
  • benches makes use of network_helpers_sv2 on async_std mode

I'll send a follow-up PR soon

It's ready on my fork... I will open the PR..

@plebhash plebhash linked a pull request Feb 1, 2025 that will close this issue
Open
@plebhash
Copy link
Collaborator Author

plebhash commented Feb 1, 2025

re-opening, as we still have some left-overs:

  • network_helpers_sv2 has async_std modules
  • benches makes use of network_helpers_sv2 on async_std mode

I'll send a follow-up PR soon

It's ready on my fork... I will open the PR..

sorry only saw this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shourya742 Shourya742

Labels
async refactor Implies refactoring code roles Pertains to all roles
Projects
SV2 Roadmap 🛣️
Status: Todo 📝
Milestone
1.3.0
3 participants
@Fi3 @Shourya742 @plebhash