Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove async std from translator #1424

Conversation

Shourya742
Copy link
Contributor

partially closes: #1402

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 17.97%. Comparing base (300ad13) to head (933495b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...es/translator/src/lib/downstream_sv1/downstream.rs 0.00% 29 Missing ⚠️
roles/translator/src/lib/mod.rs 0.00% 1 Missing ⚠️
...translator/src/lib/upstream_sv2/diff_management.rs 0.00% 1 Missing ⚠️
roles/translator/src/lib/upstream_sv2/upstream.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1424      +/-   ##
==========================================
- Coverage   18.40%   17.97%   -0.44%     
==========================================
  Files         156      167      +11     
  Lines       10945    11925     +980     
==========================================
+ Hits         2014     2143     +129     
- Misses       8931     9782     +851     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.40% <ø> (ø)
binary_sv2-coverage 5.11% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.12% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.27% <ø> (ø)
jd_client-coverage 0.38% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.34% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.25% <ø> (ø)
pool_sv2-coverage 2.04% <ø> (ø)
protocols 23.86% <ø> (ø)
roles 5.84% <0.00%> (+2.38%) ⬆️
roles_logic_sv2-coverage 8.70% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 8.74% <0.00%> (?)
utils 25.13% <ø> (ø)
v1-coverage 2.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shourya742 Shourya742 force-pushed the 2025-01-30-remove-async-std-from-translator branch from b5a627c to 2971721 Compare January 30, 2025 13:53
@plebhash plebhash added ready-to-be-merged triggers auto rebase bot refactor Implies refactoring code translator proxy SV1>SV2 translator proxy issues roles Pertains to all roles labels Feb 1, 2025
@pavlenex pavlenex force-pushed the 2025-01-30-remove-async-std-from-translator branch from 2971721 to eb36259 Compare February 1, 2025 02:55
@pavlenex pavlenex force-pushed the 2025-01-30-remove-async-std-from-translator branch from eb36259 to 933495b Compare February 1, 2025 03:07
@plebhash plebhash merged commit d9d7ec7 into stratum-mining:main Feb 1, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-be-merged triggers auto rebase bot refactor Implies refactoring code roles Pertains to all roles translator proxy SV1>SV2 translator proxy issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove async_std support
3 participants